-
Notifications
You must be signed in to change notification settings - Fork 1k
RFC: pkg 6.0 #1655
Comments
YES BRO, YES. |
Finally, no need to rollup before compiling with ESM, nice 🚀 |
Love it! 🚢 |
https://github.com/Ylianst/Authenticode-JS sample code:
|
@si458 Awesome! ❤️ |
@si458 Here's a better option. Works for me perfectly. |
There is a compatibility issue with workers that are annoying; please consider these: |
Is bytecode/sourceless support for ES Modules something that could be added? |
is it possible to include the ability to specify icons for mac /windows ? |
what time the v6 will release? |
Lol, After changing the icon, I got this
|
Currently I use resedit to modify icons. After testing, it is found that this problem will occur when the icon file is larger than 100kb. |
Wow, life saver i will try it |
can you link the github on the npm page and some description on how to use it? |
I updated some docs explaining how I use it |
this only works for windows, right? how do you do it for mac? |
It's just a wrapper around the resedit library, so it's only valid for win. https://stackoverflow.com/questions/57251019/is-it-possible-to-change-any-apps-icon-with-nodejs |
This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label |
I'm guessing this is not stale. |
I'm looking forward for the ESM feature :) |
@julianpoemp not sure we will ever see it. There is actually no one maintaining this project. |
Bun nodejs support is still not production ready unfortunately. Also deno supports compile: https://docs.deno.com/runtime/manual/tools/compiler Anyway for most nodejs projects of a certain size them would be almost impossible to use at this time for compatibility issues |
Also worth notice that bkg doesn't compile the source code into bytecode:
https://github.com/theseyan/bkg#differences-from-pkg It actually works like caxa |
if someone is facing issues with ESM modules I recommend to use ncc as a pre step before bundling with pkg. It even seems to reduce the size of the executable, in my case by 30%. Before using vercel/ncc I had to add a lot of dependencies to assets property, now it's much less. |
The typescript settings it requires means it also requires a prior bundling step for ESM code, which is not a solution to the problem at hand. |
For anyone that is interested in this project, giving that I don't receive any feedback from Vercel anymore, I created my own forks of both pkg and pkg-fetch: If someone is interested in helping me create a PR or move your active PR to those repositories. Thanks 🙏🏼 |
@julianpoemp can confirm using It's really unfortunate this project is no longer maintained by @vercel-infra. Bun is great but doesn't support Windows yet and it's very common for npm packages not to work. I feel like it's unlikely Bun and certainly Deno will achieve 1:1 compatibility with Node.JS in the near future. I've got high hopes that Bun will eventually get there though 🤞 |
The text was updated successfully, but these errors were encountered: