Use Netty's MqttMessageBuilders when possible #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@francois-travais can you check and resolve conflicts before I start the review please? Thanks! |
|
ping @francois-travais |
|
@francois-travais ping |
|
we would like to merge this in master for Vert.x 4 |
francois-travais
force-pushed
the
master
branch
from
45ba163 to
779017d
Compare
francois-travais
force-pushed
the
master
branch
from
779017d to
2fe08ce
Compare
|
@vietj I rebased. I'm not sure whether the failing tests are a consequence of the changes I made. |
|
@francois-travais can you rebase again, then we can merge it for 4.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13.
We cannot use
MqttMessageBuildersforPUBLISHmessages because the implementation forcesisDuptofalse.