Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting the Domain attribute on the session cookie #2686

Open
fbuetler opened this issue Nov 26, 2024 · 1 comment · May be fixed by #2687
Open

Allow setting the Domain attribute on the session cookie #2686

fbuetler opened this issue Nov 26, 2024 · 1 comment · May be fixed by #2687
Labels
enhancement

Comments

@fbuetler
Copy link
Contributor

Version

4.5.8

Context

The current API of the SessionHandler does not support setting the domain attribute of the session cookie.

If the web server is serving multiple hosts, it would be convenient to use the same session for the same client by setting the domain attribute of the session cookie.

Additional Information

If accepted, I volunteer to contribute this.
@fbuetler fbuetler added the bug label Nov 26, 2024
This was referenced Dec 4, 2024
Open
Open
@tsegismont tsegismont added enhancement and removed bug labels Jan 2, 2025
@tsegismont
Copy link
Contributor

I have mixed feelings about this one. It's nice to have but I would like to fully understand consequences, with respect to possible attacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set domain on session cookie in session handler fbuetler/vertx-web
2 participants
@tsegismont @fbuetler