Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow marking a file as skipped #59

Open
jaybosamiya opened this issue Apr 23, 2024 · 0 comments
Open

Allow marking a file as skipped #59

jaybosamiya opened this issue Apr 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jaybosamiya
Copy link
Collaborator

Currently, a file needs to be parse-able to be able to add a #[verusfmt::skip] declaration to an item. However, it should be possible to support a file-level #![verusfmt::skip] declaration that doesn't need any parser support (at least nothing any further than src/verus-minimal.pest).

This can help unblock new syntax or features in Verus that are being blocked by yet-to-be-added support in verusfmt. However, I am concerned that this might lead to files being accidentally left as unformatted for too long. One mitigation for this is to attempt a parsing check anyways if #![verusfmt::skip] is found, and if parsing succeeds, then throw in a warning saying that more specific #[verusfmt::skip]s are preferred. If we're being fancy, we can even suggest locations to insert those in based on the results of --check, but I think at minimum, an implementation of this should do a "warn if parsing succeeds" check.


CC: @Chris-Hawblitzel who asked if there was a way to skip an entire file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant