Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: drop support to python 2.7 #231

Open
domdinicola opened this issue Jul 21, 2020 · 7 comments
Open

Proposal: drop support to python 2.7 #231

domdinicola opened this issue Jul 21, 2020 · 7 comments

Comments

@domdinicola
Copy link
Contributor

domdinicola commented Jul 21, 2020

If @vgrem you agree I can create a PR to address this

@vgrem
Copy link
Owner

vgrem commented Jul 21, 2020

@domdinicola might be a good idea, thanks! Although would be interested to get familiar with runtime usage statistics.

p.s. and might be slow with response since on vacation until the end of the month

@domdinicola
Copy link
Contributor Author

based on this https://en.wikipedia.org/wiki/History_of_Python we should be able to get rid of those since are not officially supported anymore.
enjoy your vacation!

@hugovk
Copy link

hugovk commented Jul 22, 2020

Here's the pip installs for Office365-REST-Python-Client from PyPI for June 2020:

category percent downloads
3.7 78.80% 32,146
3.6 12.61% 5,144
3.5 5.80% 2,367
3.8 1.80% 736
2.7 0.58% 235
null 0.39% 161
3.4 0.01% 6
Total 40,795

Source: pip install -U pypistats && pypistats python_minor Office365-REST-Python-Client --last-month

@domdinicola
Copy link
Contributor Author

Since between 3.6 and 3.7 we reach more than 90%, I think we can drop 3.5 and 2.7 (3.4 is already not supported)
#233

@kellerza
Copy link
Contributor

kellerza commented Oct 5, 2023

This is probably a good time to drop Python 2:

  • Stats shows we can drop Python < 3.7
  • Requests only supports 3.7+
  • There are several typing improvements in Python 3
  • Adding async support would need Python 3
  • There are already f-strings used in several places (not intentional)
category percent downloads
3.9 52.46% 2,456,724
3.8 27.40% 1,283,225
3.7 9.65% 451,871
3.10 6.56% 307,105
3.11 2.57% 120,140
3.12 0.00% 221
null 0.80% 37,480
3.6 0.50% 23,574
2.7 0.05% 2,464
3.5 0.00% 46
3.3 0.00% 3
3.4 0.00% 3
Total 4,682,856

@kellerza
Copy link
Contributor

kellerza commented Oct 5, 2023

@domdinicola still interested to work this? (It's hacktoberfest after all 😉)

I've done some typing improvements (#747) and will try to get the most of the static checks passing. Once passing, it's probably a good time to do this. The new typing format is very similar to what we'll use in Python 3, but since it's still supported in Python 3 we don't have to convert everything in one PR. To keep it smaller, probably removing compat.py would be the best start

@vgrem suggested to move to v 3.0.0 of the library

@domdinicola
Copy link
Contributor Author

@kellerza agree, if needed I could help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants