Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "sr" preset and lock it out of paired-end modes so it doesn't look like the right choice for short reads #4487

Open
adamnovak opened this issue Jan 6, 2025 · 0 comments · Fixed by #4488

Comments

@adamnovak
Copy link
Member

Right now lr-giraffe has an sr preset which is for single-ended Illumina reads with chaining.

If you use it for paired-end Illumina reads, it can't do chaining, but it also still changes a bunch of parameters and givesd bad results with the non-chaining codepath.

We should rename it, and probably lock it out of paired-end modes.

@adamnovak adamnovak linked a pull request Jan 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant