Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback & quit_confirm feature request #189

Closed
ttytm opened this issue May 7, 2022 · 5 comments
Closed

feedback & quit_confirm feature request #189

ttytm opened this issue May 7, 2022 · 5 comments

Comments

@ttytm
Copy link

ttytm commented May 7, 2022

Hello,

A little additional data safety feature I think would be awesome is triggering a quit_confirm when OS-closing the window. Causing a prompt when trying to close the client while having unsaved buffers. Maybe as an option or the default behavior. What do you think about such a thing?

And I'm coincidentally seeing the good news that it'll be ported to gtk4. Man, thanks for developing such a great client! What I always liked most about gnvim that it had the most flawless implementation of smooth scrolling. Coconut oily smooth animations and no jumpiness when scrolling over folds. Makes it a pleasure to use. Imho none of the other nvim UIs can compete with this.

Sending love and blessings

@vhakulinen
Copy link
Owner

Would sending :qa to nvim when you press the close button do the trick? I think that would be the "correct" thing to do.

And thank you for the kind words.

@ttytm
Copy link
Author

ttytm commented May 8, 2022

Hello,
Nice to read your reply. Yes, that's what I thought of! System-closing a window I usually do with meta+q. A workaround I tried to achieve this, was to integrate the gdk superkey modifier into the modifier keylist and then to map this comb inside vim to :qa. Unfortunately that didn't work out. Also, this is probably more complicated than what it needs to be for this simple purpose.

@dbarnett
Copy link

Looks like confirm on close was previously requested in #147.

@ttytm
Copy link
Author

ttytm commented Jun 19, 2022

Looks like confirm on close was previously requested in #147.

Oh, exactly. Must have missed that. And like you mentioned in the other issues there are multiple of those requests.
Hope it gets implemented soon. Unfortunately I currently don't have the time to work my way into how to apply that into the window close event.

@vhakulinen
Copy link
Owner

Closing as duplicate of #147.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants