Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GUI font requester #98

Open
dbarnett opened this issue Aug 19, 2019 · 4 comments
Open

Support GUI font requester #98

dbarnett opened this issue Aug 19, 2019 · 4 comments
Labels
good first issue Good for newcomers

Comments

@dbarnett
Copy link

On some platforms you can execute

:set guifont=*

to bring up a font requester dialog and interactively pick your font. Screenshot:
image

Could GNvim implement that font requester option for set guifont=*?

@smolck
Copy link
Contributor

smolck commented Aug 19, 2019

We could add that feature in theory, but I’m not sure if it’s something we want to add. It depends on how much we’re willing to stray from the keyboard-centric, Vim feeling. Such a feature, while convenient for some, may make GNvim’s overall UI a bit inconsistent. ATM GNvim is more of an enhanced Neovim, as opposed to what one would consider a traditional GUI text editor; this feature could change that, which may or may not be desired.

An alternative would be to open a keyboard-centric interface when the user enters set guifont=* (maybe like Startify’s) within GNvim which would allow the user to choose these font-related options. However, this would be more difficult, and likely outside the scope of GNvim (although a GNvim-specific plugin for this is an option).

All that being said, this feature is a convenience which I think we should look into; I’m not sure what route we want to take though, so some discussion is probably a good idea. @vhakulinen @badosu what do you think?

@justinmk
Copy link

:browse {cmd} exists already in n/vim for some commands. We could maybe add some event so that

:browse set

gives UIs a chance to handle it.

@bfredl
Copy link
Contributor

bfredl commented Aug 19, 2019

Though :set guifont=* is already forwarded as-is by nvim core, i e option_set["guifont", "*"], so a GUI could handle it like gvim if it wants to.

@vhakulinen
Copy link
Owner

I did have the idea of opening gui font selector on :set guifont=*, but forgot that at some point. Shouldn't be too hard to implement either.

@vhakulinen vhakulinen added the good first issue Good for newcomers label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants