Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heads up: dmd fix for alias parameter missing qualifier breaks unittest #2455

Open
ntrel opened this issue Jun 25, 2020 · 0 comments · May be fixed by #2458
Open

Heads up: dmd fix for alias parameter missing qualifier breaks unittest #2455

ntrel opened this issue Jun 25, 2020 · 0 comments · May be fixed by #2458

Comments

@ntrel
Copy link

ntrel commented Jun 25, 2020

Hi,
My pull for dmd:
dlang/dmd#11320

breaks a unittest in utils/vibe/internal/meta/codegen.d:
https://github.com/vibe-d/vibe.d/blob/master/utils/vibe/internal/meta/codegen.d#L95

My dmd pull needs that line:

static assert (getSymbols!Type.stringof == TypeTuple!(A, B).stringof);

Changed to:

static assert (getSymbols!Type.stringof == TypeTuple!(A, const(B), const(A)).stringof);

Does that look correct?
@ntrel ntrel linked a pull request Jul 10, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

meta/codegen.d: Fix getSymbols for dlang/dmd#11320 ntrel/vibe.d
1 participant
@ntrel