Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance #52

Open
jhovad opened this issue Nov 24, 2021 · 1 comment
Open

Performance #52

jhovad opened this issue Nov 24, 2021 · 1 comment

Comments

@jhovad
Copy link

jhovad commented Nov 24, 2021

I have about 1500 redirects with regexs and redirector made my app significantly slower because of querying database each request. Maybe it would be great to implement some cache.

I moved to https://github.com/jtrupiano/rack-rewrite for this amount of redirects.

No criticism of this gem, it may have good use cases when you need to build up db of redirects or you run very small app ... I'm just leaving note here for someone in situation when set of redirects is larger and finished ...

@efatsi
Copy link
Contributor

efatsi commented Nov 24, 2021

Thanks @jhovad. A cache seems like a worthy cause for large scale use cases. We don't have any active maintainers of this gem anymore unfortunately. If you were sticking with it I'd encourage you to throw a PR in, but it sounds like you've found a more performant path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants