Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the output of create does not contain long lines #111

Open
vil02 opened this issue Oct 3, 2024 · 2 comments
Open

Ensure that the output of create does not contain long lines #111

vil02 opened this issue Oct 3, 2024 · 2 comments
Assignees
Labels

Comments

@vil02
Copy link
Owner

vil02 commented Oct 3, 2024

The output of create contains some very long lines. Modify the code in such a way, that each line of the output is at most 88 characters long.

How to see the problem

Generate and inspect any puzzle, for example by running

poetry run python3 examples/basic_usage.py > example_output.py

and opening the generated example_output.py file.

Testing strategy

Adding a line like

assert all(len(_) <= 88 for _ in in_puzzle.splitlines())

into _run_puzzle_str is a good start.

@vil02 vil02 added good first issue Good for newcomers hacktoberfest labels Oct 3, 2024
@mpa-LHutchinson
Copy link

Hi @vil02 , can you assign this issue to me? I'll get working on it as soon as I can today

@vil02
Copy link
Owner Author

vil02 commented Oct 3, 2024

@mpa-LHutchinson: if you would like to discuss something more directly, feel free to e-mail me: [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants