From ef53e342efba395dcd0905229d29176bef5ac3d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrikas=20Arnas=20Smi=C4=8Dius?= Date: Mon, 7 Aug 2023 12:30:51 +0300 Subject: [PATCH 1/2] Update Detekt 1.17.1 -> 1.23.1 --- buildSrc/src/main/kotlin/Dependencies.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildSrc/src/main/kotlin/Dependencies.kt b/buildSrc/src/main/kotlin/Dependencies.kt index 3e0a254..6a3cc19 100644 --- a/buildSrc/src/main/kotlin/Dependencies.kt +++ b/buildSrc/src/main/kotlin/Dependencies.kt @@ -9,7 +9,7 @@ object Versions { const val MOCKITO_KOTILN = "3.2.0" const val CORE_KTX = "1.2.0" const val FRAGMENT_KTX = "1.2.4" - const val DETEKT_RUNTIME = "1.17.1" + const val DETEKT_RUNTIME = "1.23.1" const val LIFECYCLE = "2.2.0" const val COMPILE_SDK_VERSION = 29 From 2de293461d441bff6ad3aad36256d117a3005d30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrikas=20Arnas=20Smi=C4=8Dius?= Date: Tue, 8 Aug 2023 10:57:30 +0300 Subject: [PATCH 2/2] Update Detekt config and remove unused variable --- detekt/config.yml | 109 ------------------ .../java/com/vinted/coper/CoperImplTest.kt | 1 - 2 files changed, 110 deletions(-) diff --git a/detekt/config.yml b/detekt/config.yml index 6e3fbdd..07e4068 100644 --- a/detekt/config.yml +++ b/detekt/config.yml @@ -214,115 +214,6 @@ exceptions: - Throwable - RuntimeException -formatting: - active: true - android: false - autoCorrect: true - AnnotationOnSeparateLine: - active: false - autoCorrect: true - ChainWrapping: - active: true - autoCorrect: true - CommentSpacing: - active: true - autoCorrect: true - EnumEntryNameCase: - active: false - autoCorrect: true - Filename: - active: true - FinalNewline: - active: true - autoCorrect: true - insertFinalNewLine: true - ImportOrdering: - active: false - autoCorrect: true - Indentation: - active: false - autoCorrect: true - indentSize: 4 - continuationIndentSize: 4 - MaximumLineLength: - active: true - maxLineLength: 120 - ModifierOrdering: - active: true - autoCorrect: true - MultiLineIfElse: - active: true - autoCorrect: true - NoBlankLineBeforeRbrace: - active: true - autoCorrect: true - NoConsecutiveBlankLines: - active: true - autoCorrect: true - NoEmptyClassBody: - active: true - autoCorrect: true - NoEmptyFirstLineInMethodBlock: - active: false - autoCorrect: true - NoLineBreakAfterElse: - active: true - autoCorrect: true - NoLineBreakBeforeAssignment: - active: true - autoCorrect: true - NoMultipleSpaces: - active: true - autoCorrect: true - NoSemicolons: - active: true - autoCorrect: true - NoTrailingSpaces: - active: true - autoCorrect: true - NoUnitReturn: - active: true - autoCorrect: true - NoUnusedImports: - active: true - autoCorrect: true - NoWildcardImports: - active: true - PackageName: - active: true - autoCorrect: true - ParameterListWrapping: - active: true - autoCorrect: true - indentSize: 4 - SpacingAroundColon: - active: true - autoCorrect: true - SpacingAroundComma: - active: true - autoCorrect: true - SpacingAroundCurly: - active: true - autoCorrect: true - SpacingAroundDot: - active: true - autoCorrect: true - SpacingAroundKeyword: - active: true - autoCorrect: true - SpacingAroundOperators: - active: true - autoCorrect: true - SpacingAroundParens: - active: true - autoCorrect: true - SpacingAroundRangeOperator: - active: true - autoCorrect: true - StringTemplate: - active: true - autoCorrect: true - naming: active: true ClassNaming: diff --git a/library/src/test/java/com/vinted/coper/CoperImplTest.kt b/library/src/test/java/com/vinted/coper/CoperImplTest.kt index f1424ca..6eb8954 100644 --- a/library/src/test/java/com/vinted/coper/CoperImplTest.kt +++ b/library/src/test/java/com/vinted/coper/CoperImplTest.kt @@ -813,7 +813,6 @@ class CoperImplTest { fun request_permissionRequestReturnsDifferentPermissions_throwException() { runBlocking { val requestedPermission = "requested_permission" - val resultedPermission = "resulted_permission" executePermissionRequest( permissionsToRequest = listOf(requestedPermission),