Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logs #167

Open
Davidson-Souza opened this issue May 28, 2024 · 7 comments
Open

Improve logs #167

Davidson-Souza opened this issue May 28, 2024 · 7 comments
Labels
chore Cleaning, refactoring, reducing complexity enhancement New feature or request good first issue Good for newcomers

Comments

@Davidson-Souza
Copy link
Collaborator

No description provided.

@Davidson-Souza Davidson-Souza converted this from a draft issue May 28, 2024
@Davidson-Souza Davidson-Souza added enhancement New feature or request good first issue Good for newcomers chore Cleaning, refactoring, reducing complexity labels May 28, 2024
@Sweetdevil144
Copy link

Hi @Davidson-Souza . Is this issue open for the community? I would like to tackle this Issue. Can you describe what specific log types are you trying to target when you say Improve logs?

@Davidson-Souza
Copy link
Collaborator Author

Hi @Sweetdevil144 . Yes, this is open for anyone to grab.

There are a lot of things that can be improved in the current logging system. The messages can be improved to be more clear, the formatting can be less verbose... I was specially thinking about debug logging, with more useful information for digging problems. I would like better tracing log for low-level operations like OS calls and database changes.

So, the first job is probably to figure out what can be improved and made clearer

@leif-runescribe
Copy link

Hi, as this issue is related to logging, and a good first issue, I'd like to take it up

@jaoleal
Copy link
Contributor

jaoleal commented Oct 9, 2024

Do it! @leif-runescribe

@leif-runescribe
Copy link

Would you mind specifying which logs require improvements,
I figured maybe i should work on the Floresta cli error logs, but that's not very helpful is it?
As @Davidson-Souza mentioned, should i work on the low level and db related logs?

@jaoleal
Copy link
Contributor

jaoleal commented Oct 10, 2024

I would recommend to try yourself and propose your opinion for this issue.

  • Sometimes floresta starts doing ibd and stops logging. But is doing idb.

  • We dont have levels of debugging. all te time logging everything is no good for development and sometimes can waste some precious resources.

  • Its verbose

Thins like this and error handling doesnt have a pattern of implementation. We need to discuss some, feel free to propose.

@jaoleal
Copy link
Contributor

jaoleal commented Oct 10, 2024

I ended up thinking a lot about this issue. I would suggest to use the default log api and define it levels in compile time as this example here...

may this could be solved after #86 would avoid some rework 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Cleaning, refactoring, reducing complexity enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants