Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint + Prettier conflicts #25

Open
ra-phael opened this issue Feb 24, 2023 · 0 comments
Open

Eslint + Prettier conflicts #25

ra-phael opened this issue Feb 24, 2023 · 0 comments

Comments

@ra-phael
Copy link
Contributor

As part of #23
some errors appeared that seem to be a conflict between Prettier and ESLint in the following files:

mauve-dex/.eslintrc.js

Line 9 in 5932302

files: ['src/constants/chains.ts', 'src/constants/locales.ts', 'src/state/routing/utils.ts'],

I didn't dive into the issue as the eslint configuration comes from @uniswap/eslint-config. I disabled the errors (see .eslintrc).

Description

  1. Although my IDE does not complain at first, running yarn lint reports errors in the files mentioned above. For example
export type SupportedL1ChainId = typeof L1_CHAIN_IDS[number]

should be replaced with

export type SupportedL1ChainId = (typeof L1_CHAIN_IDS)[number]

...src/constants/locales.ts
36:31 error Replace typeof·SUPPORTED_LOCALES with (typeof·SUPPORTED_LOCALES) prettier/prettier

  1. Run yarn lint --fix to fix these errors.

  2. Now my IDE complains
    image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ra-phael