Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish v0.2.8 to crates.io #21

Open
mi-ael opened this issue Jan 31, 2024 · 4 comments
Open

Publish v0.2.8 to crates.io #21

mi-ael opened this issue Jan 31, 2024 · 4 comments

Comments

@mi-ael
Copy link

mi-ael commented Jan 31, 2024

Currently, v0.2.7 is the latest version of this awesome library available on crates. But on GitHub there is already a v0.2.8 version available, which fixes some issues for the current version of Bevy.

Could you publish the v0.2.8 version to crates.io?

@virtualritz
Copy link
Owner

Yes, I will get to it eventually. There are some blockers that have to do with the nsi crate.

In the meantime you can use an overlay in your Cargo.toml:

[patch.crates.io]
polyhedron-ops = { git = "https://github.com/virtualritz/polyhedron-ops.git" }

@virtualritz
Copy link
Owner

@donbright, do you want to open a PR to get the solids you added in your fork included with 0.2.8?

@donbright
Copy link
Contributor

donbright commented Mar 10, 2024

no its not ready. i mean you are free of course to do what you wish but i had not planned on doing a PR until it was perfect and there was discussion about what style of code you prefer

i was working on some way to efficiently enumerate all 92 johnson solids but havent finished yet. the way i was going was not going to be tenable. im reading Coxeter's Polytopes book to try to help me but it will be a while.

thanks for asking.

@virtualritz
Copy link
Owner

@donbright did you check the good old xscreensaver polyhedra module for inspiration? I believe to recall they had a way there that was quiet compact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants