Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Picking radius does not apply correctly in _pickClosestObject #9287

Open
1 of 7 tasks
deluksic opened this issue Dec 9, 2024 · 0 comments
Open
1 of 7 tasks
Labels

Comments

@deluksic
Copy link

deluksic commented Dec 9, 2024

Description

If I understand the picking mechanism correctly, the _pickClosestObject will render a square patch (pickingRadius x pickingRadius) of the picking buffer and find the non-null pixel closest to the center of the patch.

In case we have overlapping objects, the object in front will not get "expanded" as pickingRadius would suggest, rather the closest object will be picked regardless of which one is in front.

This means the behavior is just as if we had pickingRadius = 0.

Is there a simple way to fix this? The use case is very common, I believe: ScatterplotLayer on top of a TileLayer.

Flavors

  • Script tag
  • React
  • Python/Jupyter notebook
  • MapboxOverlay
  • GoogleMapsOverlay
  • CartoLayer
  • ArcGIS

Expected Behavior

No response

Steps to Reproduce

I will come up with an example if the problem is unclear.

Environment

  • Framework version: v9.0.36
  • Browser: Chrome
  • OS: MacOS

Logs

No response

@deluksic deluksic added the bug label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant