Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I create alarm dialog with no cancel button? #41

Open
lexer opened this issue Apr 13, 2012 · 8 comments
Open

How can I create alarm dialog with no cancel button? #41

lexer opened this issue Apr 13, 2012 · 8 comments

Comments

@lexer
Copy link

lexer commented Apr 13, 2012

Should I make my own implementation like Confirmation dialog, or it is possible to reuse confirmation dialog for this purpose?

@tj
Copy link
Member

tj commented Apr 13, 2012

hmmm yeah maybe, or use the notifications maybe?

@lexer
Copy link
Author

lexer commented Apr 13, 2012

In our app we need to show modal window that will block user until he read the message and press "Ok"

@lexer
Copy link
Author

lexer commented Apr 13, 2012

Another example. User should be blocked until he will receive response via push notification. If user don't want to wait he ca press single button "Cancel" and resume his work.

@lexer
Copy link
Author

lexer commented Apr 13, 2012

May be it would be better to modify confirmation to show ok and cancel only if they are declared. This is how android Alerts are designed for example.

new ConfirmationDialog().ok("done") - this is alarm dialog with single ok button
new ConfirmationDialog().cancel("reset") - this is alarm dialog with single cancel button.

However in this design it should be named smth like "AlarmDialog" that is more generic name.

Have you also thought about separate callbacks? .ok("done", function(){ });

@lexer
Copy link
Author

lexer commented Apr 13, 2012

I mean "AlertDialog" not alarm. We will try to make a pull request today.

@tj
Copy link
Member

tj commented Apr 13, 2012

yeah we could have an Alert and ui.alert(msg) with .modal() etc default. modals in generate are kinda bad UX but I can see in some cases if you have a critical issue that needs attention

@lexer
Copy link
Author

lexer commented Apr 13, 2012

yep sure. modal should be optional.

@lexer
Copy link
Author

lexer commented Apr 13, 2012

We have added pull request #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants