Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot assign labels when autoscaling config exists #459

Open
trinhthinh388 opened this issue Oct 3, 2024 · 2 comments
Open

[Bug] Cannot assign labels when autoscaling config exists #459

trinhthinh388 opened this issue Oct 3, 2024 · 2 comments

Comments

@trinhthinh388
Copy link

Hi team,
I've been trying out Hetzner K3s for my pet project and it is really great.
Anyway, there is an issue with labels assignment when a node pool also contains an autoscaling configs.

My configs is as follow:

- name: general-worker
    instance_type: cax11
    instance_count: 1
    location: fsn1
    labels:
      - key: purpose
        value: general

  - name: database-worker
    instance_type: cax11
    instance_count: 1
    location: fsn1
    labels:
      - key: purpose
        value: database
    autoscaling:
      enabled: true
      min_instances: 0
      max_instances: 3

And when I run the create command, it gave me this error:

[Node labels] 
Adding labels to general-worker pool workers...
[Node labels] node/redge-develop-pool-general-worker-worker1 not labeled
[Node labels] ...node labels applied
[Node labels] 
Adding labels to database-worker pool workers...
error: resource(s) were provided, but no name was specified
[Node labels] : error: resource(s) were provided, but no name was specified
@vitobotta
Copy link
Owner

Hi! It is a known problem, and I plan to address it in the next release. Label support was added to the cluster autoscaler for Hetzner only recently, and I haven't had a chance to make it work in hetzner-k3s yet. If you need labels and taints can you temporarily use a static node pool? I will try to make a new release next week and then you could migrate from the static pool to an autoscaled one.

@trinhthinh388
Copy link
Author

Hi! It is a known problem, and I plan to address it in the next release. Label support was added to the cluster autoscaler for Hetzner only recently, and I haven't had a chance to make it work in hetzner-k3s yet. If you need labels and taints can you temporarily use a static node pool? I will try to make a new release next week and then you could migrate from the static pool to an autoscaled one.

Oh that sounds great!
Thanks a lot @vitobotta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants