-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration of Cineast Features #94
Comments
Interestingly enough, some of the ones you already crossed out are among the ones I would have considered to be more interesting to keep. I think it would be good to have some interest-point bag-of-word-based feature support, as there are specific use cases, such as sub-image or near-duplicate matching, where they are still very useful. It is debatable what exact method for interest-point detection and description should be employed. For the other ones, everything that ends in 'Reduced' does not need to be a dedicated feature, as it was a version of another feature that applied a color reduction operation first. While this can be useful for doing things like aligning color palettes for, e.g., sketch-based retrieval, this can now be a dedicated pre-processing step. |
Thanks for the comment. I agree on your point on the BoW features for near-duplicate matching. However, don't think those two features are particularly useful. If anything, I'd add something new for this purpose. Talking about near-duplicate detection: Didn't we once have a Master's Thesis dealing with this topic? What about DominantColor? Having information about dominant colors in an image could certainly be useful, even in the future. |
Ohh and one remark regarding |
Regarding the dominant color, I guess what would be more useful is to have this as a label rather than a vector. So, what I would see as useful is defining a palette of colors and having a feature that assigns one (or none) of these. The Cineast DominantColor feature did produce a vector with the most dominant color and then used knn on it, that's probably less useful. For the SkeletonPose: yes, this will probably not be easily supported by the pgVector connection. I foresee that this would require a new type of query object that has to be supported by the connection. Even if the feature by itself is probably only useful in some somewhat narrow use cases, it might still be interesting to have, if only as a demonstration, of how custom querying logic can be supported in a connection. |
Regarding the ConceptMaskADE20k feature, that one was used for query by semantic sketch. I guess having such a query mode back would also be interesting in the medium term. From the implementation side of things, I'd, however, rather use something like https://github.com/apple/ml-4m/ in the backend. |
I'd suggest to open separate issues for new feature requests. Regarding DominantColor: I agree with your assessment. Is this something that can be derived using the existing feature? Or is this something completely different. |
It's probably easier to build this freshly than trying to adapt the old one. I guess one would have to first have to come up with a concise definition of a dominant color in this context, as color is not as straightforward as one might think 😉. I can take care of this at some point. |
I see! So I've updated the TODO-List - which is quite short at this point. @faberf Any chance you might be able to add these features to the FES in the near future? |
Task Description
As discussed during our last meeting, I have removed the 'migration' features from the code base. The purpose of this issue is to discuss and decide, which of the legacy Cineast features should be kept and migrated and to migrate them eventually. I simply start with a list of all the features that have had a migration feature:
Keep / Migrate
Add to FES (@faberf)
Drop / Remove
AverageColorGrid8Reduced15(basically an existing feature with a pre-processing step)AverageFuzzyHistAverageFuzzyHistNormalizedDominantColorDominantEdgeGridDominantEdgeGrid8DominantEdgeGrid16EdgeARP88EdgeGrid16InceptionResNetVMedianFuzzyHistCLDReduced15ConceptMasksADE20HOGMF25k512(obsolete)OpenCLIP(better option available)ProvidedOCR(not needed as a feature, create an import script)SURFMF25K512(obsolete)WhisperASR(better option available)I have already singled-out some of the feature I would probably drop. Maybe @lucaro can weigh-in on the others and describe what they bring to the table.
Dependencies
None
Boundary Conditions
Only features that are useful should be migrated (e.g., in terms for functionality or didactically to illustrate how features can be built). No need to keep legacy features that bring no advantage.
The text was updated successfully, but these errors were encountered: