Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit export of Reactions #12

Open
HeikoKlare opened this issue Mar 6, 2018 · 1 comment
Open

Explicit export of Reactions #12

HeikoKlare opened this issue Mar 6, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@HeikoKlare
Copy link
Contributor

HeikoKlare commented Mar 6, 2018

Currently, a ChangePropagationSpecification is created for each Reactions segment in the default package mir.reactions.SEGMENT_NAME.
To provide a clean interface to the generated code, we should introduce a kind of export keyword that explicitly marks a segment to be exported and accessed by applications. Therefore, it should be possible to define a package in which the ChangePropagationSpecification for that segment should be created.
We could then disable the generation of ChangePropagationSpecification for each segment per default.

Together with that fix, we should change the default namespace of Reactions and Routines since the term mir is outdated. We could use something generic in our namesapce like tools.vitruv.consistency.*.

@HeikoKlare HeikoKlare added the enhancement New feature or request label Mar 6, 2018
@HeikoKlare
Copy link
Contributor Author

There is another reason to have an export keyword: WIth the new design, we have to define an explicit segment that combines all segments that shall be used in one ChangePropagationSpecification. If there are routines with conflicting names in these segments, they must be imported with qualified names, although this segment does have the purpose to use or even modify routines. Therefore, we should treat the export segments completely different and not allow to define additional reactions and routines there and also not allow to import them anywhere else.

@HeikoKlare HeikoKlare transferred this issue from vitruv-tools/Vitruv Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant