Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse filter results on page #473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

litvinovg
Copy link
Contributor

@litvinovg litvinovg commented Sep 16, 2024

VIVO PR

What does this pull request do?

Adds an option to select search filter to display filtered results on custom page.

What's new?

Refactored PagedSearchController.
Added search filter option to ManagePageGenerator
Refactored ProcessN3GetterDataMap
Created new data getter class display:SearchFilterValuesDataGetter , java implementation in SearchFilterValuesDataGetter.java
Created boolean data property search:reverseFacetOrder to reverse sort order of facets.
Created filters to filter result in alphabetical indexes
:filter_label_regex - default regex filter that uses i18n field :field_label_display with name locale + _label_display
:filter_raw_label_regex - fallback regex filter that uses nameRaw search field for VIVO instances without i18n support

How should this be tested?

A description of what steps someone could take to:

  • Create a new page in PageManagement menu. use type filter as an example
  • Browse page, try selecting facets, alphabetical index, pagination
  • Test the same in non i18n VIVO

Additional Notes:

This change require documentation to be updated.

Interested parties

@hauschke @VIVO-project/vivo-committers

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. Java
  2. JavaScript
  3. FreeMarker
  4. SPARQL
  5. Ontologies
  6. Natural language knowledge
    1. English
    2. German
    3. Spanish
    4. French
    5. Portuguese
    6. Russian
    7. Serbian

Reviewers' report template

Please update the following template which should be used by reviewers.

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browse filter results on custom page
1 participant