Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwmon model is an invalid keyword #244

Open
bhundven opened this issue Jun 13, 2024 · 4 comments
Open

hwmon model is an invalid keyword #244

bhundven opened this issue Jun 13, 2024 · 4 comments
Assignees
Labels
feedback wanted regression Something broken that used to work

Comments

@bhundven
Copy link
Contributor

In #211, I implemented the hwmon model config option.
In the latest git build, model is no longer valid:

config:

  - hwmon: /sys/class/hwmon
    name: nvme
    model: WD_BLACK SN770 1TB
    indices: [1]

log:

Jun 13 13:12:57 mill systemd[1]: Starting thinkfan.service - thinkfan 2.0.0...
Jun 13 13:12:57 mill thinkfan[16494]: ERROR: /etc/thinkfan.conf:10:
                                          model: WD_BLACK SN770 1TB
                                          ^
                                      Invalid keyword.

This is on the current head: b1ad819

vmatare added a commit that referenced this issue Oct 15, 2024
Must have been lost during some refactoring. Fixes github issue #244.
@vmatare vmatare self-assigned this Oct 15, 2024
@vmatare vmatare added regression Something broken that used to work feedback wanted labels Oct 15, 2024
@vmatare
Copy link
Owner

vmatare commented Oct 15, 2024

Should be fixed in latest master.

@bhundven
Copy link
Contributor Author

Tested on Fedora Workstation 41.

@bhundven
Copy link
Contributor Author

So this is "kind of fixed". Let me get some more info an elaborate.

@bhundven
Copy link
Contributor Author

Here is my config:

---
sensors:
  - tpacpi: /proc/acpi/ibm/thermal
  - nvml: 01:00.0
  - hwmon: /sys/class/hwmon
    name: coretemp
    indices: [1, 2, 3, 4, 5, 6, 7, 8, 9]
  - hwmon: /sys/class/hwmon
    name: nvme
    indices: [1]
    model: WD_BLACK SN770 1TB

fans:
  - tpacpi: /proc/acpi/ibm/fan

levels:
  - ["level 0", 0, 28]
  - ["level auto", 25, 55]
  - ["level 6", 50, 75]
  - ["level 7", 70, 110]
  - ["level full-speed", 105, 9000]

I have an internal nvme named:

$ cat /sys/class/hwmon/hwmon3/name 
nvme
$ cat /sys/class/hwmon/hwmon3/device/model 
WD_BLACK SN770 1TB

And sometimes an external nvme for backup (thunderbolt 4):

$ cat /sys/class/hwmon/hwmon4/name 
nvme
$ cat /sys/class/hwmon/hwmon4/device/model 
WDS200T1XHE-00AFY0

With both plugged in with the above config, I get:

ERROR: hwmon sensor driver: /sys/class/hwmon: Found multiple hwmons with this name:  /sys/class/hwmon/hwmon4 /sys/class/hwmon/hwmon3

If I comment out name:

  - hwmon: /sys/class/hwmon
    # name: nvme
    indices: [1]
    model: WD_BLACK SN770 1TB

Then this works. indices seems to be needed to be set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted regression Something broken that used to work
Projects
None yet
Development

No branches or pull requests

2 participants