Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try simplify EqualError in item_hook_handler_test.go #8181

Closed
kaovilai opened this issue Sep 3, 2024 · 2 comments
Closed

Try simplify EqualError in item_hook_handler_test.go #8181

kaovilai opened this issue Sep 3, 2024 · 2 comments
Assignees
Labels

Comments

@kaovilai
Copy link
Contributor

kaovilai commented Sep 3, 2024

To simplify EqualError comparing error to error, rather than string compared to err

/assign me

          I believe it’s out of scope of this PR. This only apply best practices while keeping actual tests working. Maybe you can do a PR following your suggestion in the same time ?

Originally posted by @mmorel-35 in #8027 (comment)

Copy link

github-actions bot commented Nov 4, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

@github-actions github-actions bot added the staled label Nov 4, 2024
@kaovilai
Copy link
Contributor Author

kaovilai commented Nov 4, 2024

obsolete by #8027 closing.

@kaovilai kaovilai closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant