Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node.kubernetes.io/instance-type label to nodes #312

Open
viveksyngh opened this issue Nov 2, 2023 · 1 comment
Open

Add node.kubernetes.io/instance-type label to nodes #312

viveksyngh opened this issue Nov 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@viveksyngh
Copy link
Member

Is your feature request related to a problem? Please describe.

We would like to add node.kubernetes.io/instance-type labels to nodes provisioned using CAPVCD similar to other cloud provider node.kubernetes.io/instance-type.

https://kubernetes.io/docs/reference/labels-annotations-taints/#nodekubernetesioinstance-type

Describe the solution you'd like

We can add the sizing policy of VCDMachine object as instanceType of the nodes. These labels can be added as metadata in init or join configuration of the nodes.

Check the original issue vmware/cluster-api-provider-cloud-director#536

Describe alternatives you've considered

No response

Additional context

No response

@viveksyngh viveksyngh added the enhancement New feature or request label Nov 2, 2023
@srekkas
Copy link

srekkas commented Sep 13, 2024

Would be nice to have labels e.g. worker pool name, instance size (large, medium ..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants