Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Enable-SupervisorCluster to name a supervisor cluster #764

Open
1 of 4 tasks
benhtodd opened this issue Sep 20, 2024 · 3 comments · May be fixed by #784
Open
1 of 4 tasks

Add support for Enable-SupervisorCluster to name a supervisor cluster #764

benhtodd opened this issue Sep 20, 2024 · 3 comments · May be fixed by #784
Assignees
@tenthirtyam
Labels
enhancement Enhancement vvs/dri Developer Ready Infrastructure
Milestone
v2.12.1

Comments

@benhtodd
Copy link

benhtodd commented Sep 20, 2024 •
edited by tenthirtyam
Loading

Code of Conduct

  • I have read and agree to the project's Code of Conduct.
  • Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
  • Do not leave "+1" or other comments that do not add relevant information or questions.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

Would like Enable-SupervisorCluster to be able to name the Supervisor cluster with a custom name. Currently it names the supervisor from the parameter -Cluster which is clearly documented as The name of the vSphere cluster. There is a parameter -mastetDNSName which is documented as "The master DNS name." Which I am not so sure I know what it means. I tried it for my purposes to no avail.

Use Case(s)

Is it a must the Supervisor Cluster is to be named the same as the vsphere cluster?

Potential Configuration

Parameter called -supervisorName....?

References

No response
@benhtodd benhtodd added enhancement Enhancement needs-review Needs Review labels Sep 20, 2024
@github-actions github-actions bot added the pending-review Pending Review label Sep 20, 2024
@tenthirtyam tenthirtyam removed pending-review Pending Review needs-review Needs Review labels Sep 20, 2024
@tenthirtyam tenthirtyam added this to the Backlog milestone Sep 20, 2024
@tenthirtyam tenthirtyam added the vvs/dri Developer Ready Infrastructure label Sep 20, 2024
@tenthirtyam tenthirtyam changed the title Enable-SupervisorCluster - name Supervisor Cluster Add support for Enable-SupervisorCluster to name a supervisor cluster Sep 23, 2024
@tenthirtyam
Copy link
Collaborator

Looks like this is simply based on the current logic of the function that includes:

Cluster = (Get-Cluster -Name $cluster)

For example:

param (
    [Parameter (Mandatory = $true)] [ValidateNotNullOrEmpty()] [String]$cluster,
    [Parameter (Mandatory = $false)] [ValidateNotNullOrEmpty()] [String]$supervisorName
)

# other...

if ($inputParameterValidation -eq $true) {
    $internalWMClusterInput = @{
        # other...
        Cluster = $supervisorName -or (Get-Cluster -Name $cluster)
        # other...
    }
}

# other...

This way, if $supervisorName is provided, it will be used directly; otherwise, it will get the cluster by the name $cluster.

@tenthirtyam tenthirtyam self-assigned this Nov 14, 2024
@tenthirtyam tenthirtyam modified the milestones: Backlog, v2.13.0 Nov 14, 2024
@tenthirtyam tenthirtyam added need-info Needs Additional Information and removed need-info Needs Additional Information labels Nov 15, 2024
@benhtodd
Copy link
Author

@tenthirtyam - Not able to pass supervisorName ?
image
image

@tenthirtyam
Copy link
Collaborator

My comment above is a possible fix for the function.

@tenthirtyam tenthirtyam linked a pull request Dec 17, 2024 that will close this issue
Draft
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tenthirtyam tenthirtyam

Labels
enhancement Enhancement vvs/dri Developer Ready Infrastructure
Projects
None yet
Milestone
v2.12.1
Development

Successfully merging a pull request may close this issue.

feat: set supervisor cluster name vmware/power-validated-solutions-for-cloud-foundation
2 participants
@tenthirtyam @benhtodd