Amazon Prime Gaming in game content claims fail #208

KairuByte · 2023-09-14T18:55:11Z

It appears that the in game content claims have all started using the "multi week" claims, where you need to click not only into the games page, but also "claim" on the specific reward you want in order to actually reach the claiming page. If you watch the bot work, you'll see what I mean because it stalls for a long while waiting for the content it expects.

yoshimo · 2023-09-22T19:35:52Z

The new sub pages create errors like


Current DLC: Shadow Fight 3 - Legendary Keys
[AggregateError: All promises were rejected] {
  [errors]: [
    page.click: Timeout 60000ms exceeded.
    =========================== logs ===========================
    waiting for locator('button:has-text("Get in-game content")')
    ============================================================
        at file:///fgc/prime-gaming.js:347:33 {
      name: 'TimeoutError'
    },
    page.click: Timeout 60000ms exceeded.
    =========================== logs ===========================
    waiting for locator('button:has-text("Claim your gift")')
    ============================================================
        at file:///fgc/prime-gaming.js:347:87 {
      name: 'TimeoutError'
    },
    page.click: Timeout 60000ms exceeded.
    =========================== logs ===========================
    waiting for locator('button:has-text("Claim now")')
    ============================================================
        at file:///fgc/prime-gaming.js:347:137 {
      name: 'TimeoutError'
    }
  ]
}
Current DLC: The Crew Motorfest - Freedom Bundle
[AggregateError: All promises were rejected] {
  [errors]: [
    page.click: Timeout 60000ms exceeded.
    =========================== logs ===========================
    waiting for locator('button:has-text("Get in-game content")')
    ============================================================
        at file:///fgc/prime-gaming.js:347:33 {
      name: 'TimeoutError'
    },
    page.click: Timeout 60000ms exceeded.
    =========================== logs ===========================
    waiting for locator('button:has-text("Claim your gift")')
    ============================================================
        at file:///fgc/prime-gaming.js:347:87 {
      name: 'TimeoutError'
    },
    page.click: Timeout 60000ms exceeded.
    =========================== logs ===========================
    waiting for locator('button:has-text("Claim now")')
    ============================================================
        at file:///fgc/prime-gaming.js:347:137 {
      name: 'TimeoutError'
    }
  ]
}

Primajin · 2023-11-12T10:14:06Z

Yeah it looks for a button called "Claim now" - however the button is just called "Claim" now and thus it fails.

The button was renamed to "Claim" instead of "Claim now" this causes / fixes vogler#208

Mrgaton · 2023-12-20T19:15:12Z

[AggregateError: All promises were rejected] {
[errors]: [
page.click: Timeout 60000ms exceeded.
Call log:
- waiting for locator('button:has-text("Get in-game content")')

    at free-games-claimer\prime-gaming.js:352:33,
page.click: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('button:has-text("Claim your gift")')

    at free-games-claimer\prime-gaming.js:352:87,
page.click: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('button:has-text("Claim now")')

    at free-games-claimer\prime-gaming.js:352:137

]
}
[AggregateError: All promises were rejected] {
[errors]: [
page.click: Timeout 60000ms exceeded.
Call log:
- waiting for locator('button:has-text("Get in-game content")')

    at free-games-claimer\prime-gaming.js:352:33,
page.click: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('button:has-text("Claim your gift")')

    at free-games-claimer\prime-gaming.js:352:87,
page.click: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('button:has-text("Claim now")')

    at free-games-claimer\prime-gaming.js:352:137

]
}

same :C

The button was renamed to "Claim" instead of "Claim now" this causes / fixes vogler#208

Mrgaton · 2023-12-20T21:10:42Z

Also it doesnt claim this things

KairuByte · 2023-12-22T01:14:38Z

I'm seeing the same issue after updating to latest code. I confirmed prime-gaming.js has the two changes listed in the PR, but the bot still sits on the pre-claim page.

Edit: When the bot reaches this page, it freezes

If you manually click "Claim" the bot continues. Otherwise it will time out and move on without claiming the item.

Edit edit: I describe this as "pre claim" because it is also the interface used when multiple claims are available for the same game. This isnt the page where the actual claiming happen, it is simply a list (sometimes of 1) of current offers for the game.

Edit edit edit: Also, as @Mrgaton mentioned, there is yet another button labelled as Get in-game content that seems to be having trouble. Another example is below:

Primajin · 2023-12-22T14:57:35Z

Hmm even with the newest image it still looks for "Claim Now" not "Claim" 🤔

[AggregateError: All promises were rejected] {
  [errors]: [
    page.click: Timeout 15000ms exceeded.
    =========================== logs ===========================
    waiting for locator('button:has-text("Get in-game content")')
    ============================================================
        at /fgc/prime-gaming.js:352:33 {
      name: 'TimeoutError'
    },
    page.click: Timeout 15000ms exceeded.
    =========================== logs ===========================
    waiting for locator('button:has-text("Claim your gift")')
    ============================================================
        at /fgc/prime-gaming.js:352:87 {
      name: 'TimeoutError'
    },
    page.click: Timeout 15000ms exceeded.
    =========================== logs ===========================
    waiting for locator('button:has-text("Claim now")')
    ============================================================
        at /fgc/prime-gaming.js:352:137 {
      name: 'TimeoutError'
    }
  ]
}

Could it be that a new one was never published?

Primajin · 2023-12-22T15:29:42Z

OK I think I found the issues:

The latest image is only published under :main not under :latest.

This works much better and it recognizes when I don't have an account linked:

However eventually it still fails on a couple of titles with one of two errors:

This is because our friends at Amazon sometimes use a button and sometimes use an anchor link in the HTML:

So I guess we need to make the script versatile enough to check for either a button or a link with the given text - or instead look for the css class .tw-button

Mrgaton · 2023-12-23T03:08:58Z

yes still not claiming it

sealldeveloper · 2023-12-23T11:09:44Z

On latest of the main branch and also experiencing the issue:

Printed output:

prime-gaming (***):
- Call of Duty: Warzone and Modern Warfare 2 - Hip Hop Hutch (undefined)
- League of Legends - Prime Gaming Capsule (undefined)
- New World - Ronin's Shadow Cache (undefined)
- Hearthstone - Standard Card Pack (3) (undefined)
- Diablo IV - Death's Burden Bundle Mount (undefined)
- Apex Legends - AR Pack Bundle (undefined)
- Monster Hunter Now - Wander Droplet and Potion (undefined)
- EA SPORTS FC 24 - Prime Gaming Pack #3 (undefined)
- Overwatch 2 - 5+ Tier Skips (undefined)
- Champions Ascension - Monster Part & 500 Essence (undefined)
- Paladins - Tomb Keeper Tiberius Skin (undefined)
- Dead Island 2 - From Dusk Ryan (undefined)
- Call of Duty: Mobile - Ruin - Goblin King Epic Operator Skin (undefined)
- Legends of Runeterra - Rare Prismatic Chest + Epic Wildcard (undefined)
- Battlefield 2042 - Rising Waters Weapon Skin and 1 Tier Skip (undefined)
- World of Tanks - Threestyler Package (undefined)
- Naraka: Bladepoint - Fascinated Avatar (undefined)
- Blade & Soul - Radiant Treasures Bundle – Prime Gaming (undefined)
- Cyberpunk 2077: Phantom Liberty - Amstaff (undefined)
- Aion - Daevanion Skill Bundle (undefined)
- Big Farm: Mobile Harvest - Profile Picture (undefined)
- Aion Classic - Black Gold Medal Bundle (undefined)

Logs:

Current DLC: League of Legends - Prime Gaming Capsule

page.inputValue: Timeout 60000ms exceeded.

Call log:
  - waiting for locator('input[type="text"]')
    at /fgc/prime-gaming.js:370:35

vogler · 2023-12-23T11:12:37Z

The latest image is only published under :main not under :latest.

Probably due to #229. However, the code looks like it should publish main as latest:

free-games-claimer/.github/workflows/docker.yml

Lines 32 to 36 in 9f97805

    
                     if [[ "${{ env.BRANCH }}" == "main" ]]; then 
        
                       echo "IMAGE_TAG=latest" >> $GITHUB_ENV 
        
                     else 
        
                       echo "IMAGE_TAG=${GITHUB_REF#refs/heads/}" >> $GITHUB_ENV 
        
                     fi

Don't use latest since it has no meaning, just use --pull=always.

vogler · 2023-12-23T11:13:54Z

So I guess we need to make the script versatile enough to check for either a button or a link with the given text - or instead look for the css class .tw-button

Why not span:has-text() instead of the css class?

sealldeveloper · 2023-12-23T11:14:34Z

Further addition:
Non-LOL has this error for all other titles.
Ubuntu 20 btw.

Primajin · 2023-12-23T11:16:29Z

OK I tested it again and now it should work with #274 . I changed the selector to account for both types of buttons and in case there are more than one account link buttons, it will take the first one.

Fixes:

vogler · 2023-12-23T11:17:35Z

Can check/merge after lunch.

Primajin · 2023-12-23T11:21:25Z

So I guess we need to make the script versatile enough to check for either a button or a link with the given text - or instead look for the css class .tw-button

Why not span:has-text() instead of the css class?

Yeah I guess that could also work

Use `.tw-button` css class over `button` html element selector

sealldeveloper · 2023-12-23T15:38:10Z

Working well, small issue I'm noticing is that after the claim this timeout can linger instead of detecting the successful claim:

page.inputValue: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('input[type="text"]')

    at /fgc/prime-gaming.js:370:35

#208 (comment)

vogler · 2023-12-23T17:19:06Z

@sealldeveloper I ignore the timeout now. However, it would be better to add a case for this. For which item does this happen and what is there instead of a code or account linking?

sealldeveloper · 2023-12-23T17:27:03Z

@vogler This has happened with:

Destiny 2
League of Legends: Wild Rift
Legends of Runeterra
Overwatch 2

The result is it properly being claimed but the output is just the error from timeout then it moves to the next one after waiting the timeout.

I've also noticed with EA accounts (even when properly linked) will display to 'link the account' again, resulting in never claiming the EA rewards.

Primajin added a commit to Primajin/free-games-claimer that referenced this issue Nov 12, 2023

Update prime-gaming.js

03cae51

The button was renamed to "Claim" instead of "Claim now" this causes / fixes vogler#208

Primajin mentioned this issue Nov 12, 2023

prime-gaming: 'Claim now' -> 'Claim' for external/DLC #249

Merged

Primajin added a commit to Primajin/free-games-claimer that referenced this issue Dec 20, 2023

Update prime-gaming.js

f4270e1

The button was renamed to "Claim" instead of "Claim now" this causes / fixes vogler#208

vogler closed this as completed in #249 Dec 21, 2023

vogler reopened this Dec 22, 2023

This was referenced Dec 22, 2023

Use .tw-button css class over button html element selector Primajin/free-games-claimer#1

Closed

Use .tw-button css class over button html element selector #274

Merged

vogler closed this as completed in #274 Dec 23, 2023

vogler added a commit that referenced this issue Dec 23, 2023

Merge pull request #274 from Primajin/#208-prime-gaming

e078a15

Use `.tw-button` css class over `button` html element selector

vogler added a commit that referenced this issue Dec 23, 2023

pg: DLC: ignore timeout if there is no code

ace4ef8

#208 (comment)

vogler mentioned this issue Dec 23, 2023

Successful claim with Prime Gaming DLCs is not detected #192

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Amazon Prime Gaming in game content claims fail #208

Amazon Prime Gaming in game content claims fail #208

KairuByte commented Sep 14, 2023

yoshimo commented Sep 22, 2023 •

edited

Loading

Primajin commented Nov 12, 2023

Mrgaton commented Dec 20, 2023 •

edited

Loading

Mrgaton commented Dec 20, 2023

KairuByte commented Dec 22, 2023 •

edited

Loading

Primajin commented Dec 22, 2023 •

edited

Loading

Primajin commented Dec 22, 2023 •

edited

Loading

Mrgaton commented Dec 23, 2023

sealldeveloper commented Dec 23, 2023

vogler commented Dec 23, 2023

vogler commented Dec 23, 2023

sealldeveloper commented Dec 23, 2023

Primajin commented Dec 23, 2023

vogler commented Dec 23, 2023

Primajin commented Dec 23, 2023

sealldeveloper commented Dec 23, 2023

vogler commented Dec 23, 2023 •

edited

Loading

sealldeveloper commented Dec 23, 2023 •

edited

Loading

Amazon Prime Gaming in game content claims fail #208

Amazon Prime Gaming in game content claims fail #208

Comments

KairuByte commented Sep 14, 2023

yoshimo commented Sep 22, 2023 • edited Loading

Primajin commented Nov 12, 2023

Mrgaton commented Dec 20, 2023 • edited Loading

Mrgaton commented Dec 20, 2023

KairuByte commented Dec 22, 2023 • edited Loading

Primajin commented Dec 22, 2023 • edited Loading

Primajin commented Dec 22, 2023 • edited Loading

Mrgaton commented Dec 23, 2023

sealldeveloper commented Dec 23, 2023

vogler commented Dec 23, 2023

vogler commented Dec 23, 2023

sealldeveloper commented Dec 23, 2023

Primajin commented Dec 23, 2023

vogler commented Dec 23, 2023

Primajin commented Dec 23, 2023

sealldeveloper commented Dec 23, 2023

vogler commented Dec 23, 2023 • edited Loading

sealldeveloper commented Dec 23, 2023 • edited Loading

yoshimo commented Sep 22, 2023 •

edited

Loading

Mrgaton commented Dec 20, 2023 •

edited

Loading

KairuByte commented Dec 22, 2023 •

edited

Loading

Primajin commented Dec 22, 2023 •

edited

Loading

Primajin commented Dec 22, 2023 •

edited

Loading

vogler commented Dec 23, 2023 •

edited

Loading

sealldeveloper commented Dec 23, 2023 •

edited

Loading