Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelisting favicon #664

Open
SylvainCorlay opened this issue Jul 29, 2020 · 4 comments
Open

Whitelisting favicon #664

SylvainCorlay opened this issue Jul 29, 2020 · 4 comments

Comments

@SylvainCorlay
Copy link
Member

SylvainCorlay commented Jul 29, 2020

WARNING:tornado.general:403 GET /voila/files/favicon.ico (::1): File not whitelisted
@maartenbreddels
Copy link
Member

Should we have a favicon? I think it would be nice.

@ostrokach
Copy link

For people coming from here google, this can already be accomplished by passing --VoilaConfiguration.file_whitelist="['favicon.ico'] argument to voila and putting the favicon.ico file into the same directory as your notebooks.
For more general examples, see: https://voila.readthedocs.io/en/latest/customize.html#serving-static-files.

I guess this issue is about whitelisting the favicon.ico file by default?

@jtpio
Copy link
Member

jtpio commented Dec 23, 2020

I guess this issue is about whitelisting the favicon.ico file by default?

I think so yes. Especially if the warning is constantly in the logs.

@ollyhensby
Copy link

Hello, I tried launching voila with --VoilaConfiguration.file_allowlist="['favicon.ico']", where the favicon.ico file is in the same directory as the notebook and the favicon doesn't appear. Any ideas why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants