Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace npm pack with pnpm pack in prod build script #5430

Open
kofi-q opened this issue Sep 24, 2024 · 1 comment
Open

Replace npm pack with pnpm pack in prod build script #5430

kofi-q opened this issue Sep 24, 2024 · 1 comment
Milestone

Comments

@kofi-q
Copy link
Contributor

kofi-q commented Sep 24, 2024

After the upgrade to Node v20 and NPM v10, the npm pack step of our build fails for the eslint-plugin-vx package, which has a self-reference in the dependency list. Looks like we won't have the same issue wtih pnpm pack, so worth switching over to avoid #5429 and also have more tooling consistency between our dev and prod builds.

@kofi-q kofi-q self-assigned this Sep 24, 2024
@kofi-q kofi-q added this to the v4.0 - Final milestone Sep 24, 2024
@arsalansufi
Copy link
Contributor

I'm going to move this over to v4.1 for now as it's not critical for v4 and we have things in a working state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants