Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows? #5

Open
garyng opened this issue Jul 20, 2018 · 2 comments
Open

Support Windows? #5

garyng opened this issue Jul 20, 2018 · 2 comments

Comments

@garyng
Copy link

garyng commented Jul 20, 2018

Seems like this gem does not support Windows...

@probe ||= case RUBY_PLATFORM
when /x86_64-darwin.*/
OpenStruct.new(script: 'macos', platform: 'osx-cocoa-x86-64', ext: 'pkg')
when /x86_64-linux/
OpenStruct.new(script: 'linux', platform: 'linux-generic-amd64', ext: 'tar.xz')
when /i[3456]86-linux/
OpenStruct.new(script: 'linux', platform: 'linux-generic-i386', ext: 'tar.xz')
else
raise NotImplementedError "Unsupported ruby platform #{RUBY_PLATFORM}"
end

Can we the Windows user have the support? 😉
Thanks!

@vovayartsev
Copy link
Owner

@garyng that would be nice, but I'm not a Windows user and don't feel the power to set up the environment to implement and test the feature under Windows.

I'll be happy if you or somebody else contribute and send a pull request.

@petr-motejlek
Copy link

Well. We can easily install wkhtmltopdf (the binary) ourselves on Windows (the same on the other platforms also, btw). The problem is, this piece of code just outright fails. Perhaps it could "else" to "just try to execute wkhtmltopdf in shell" and unless it fails with no such file or directory, pass the check.

Would that be possible? (I just ran into this issue when trying to use jekyll-pdf on Windows, which depends on wkhtmltopdf-installer, and won't work).

For now, I reckon I'll just switch to WSL2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants