Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test to verify factsets have required facts #208

Open
hbrown-uiowa opened this issue Nov 5, 2021 · 2 comments
Open

Regression test to verify factsets have required facts #208

hbrown-uiowa opened this issue Nov 5, 2021 · 2 comments

Comments

@hbrown-uiowa
Copy link
Contributor

It would be nice to have some code to run that would allow a fact set to be tested for the appropriate set of facts as listed on https://puppet.com/docs/puppet/7/core_facts.html (I'm not sure how often that list changes). This could catch issues like the missing mountpoints fact.

@yakatz
Copy link
Contributor

yakatz commented May 13, 2024

If the facts are only ever generated by the script and not messed with by hand, that should never be a problem.

@hbrown-uiowa
Copy link
Contributor Author

It was a problem, hence the issue.

In this particular case, a gem was not listing all of its dependencies which then caused the mountpoint facts not to get generated. Everything was done via the script, but assumptions which had been true for the script were no longer true and facts didn't get generated. If we had a test that all appropriate (whatever that gets defined to mean) facts were present, it would help detect this type of scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants