Issue #179 Add tests for empty eyaml values #322
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, when I run I made the following change: diff --git a/features/support/env.rb b/features/support/env.rb
index 1b3bfc9..5bb9b85 100644
--- a/features/support/env.rb
+++ b/features/support/env.rb
@@ -2,7 +2,7 @@ rubylib = (ENV["RUBYLIB"] || "").split(File::PATH_SEPARATOR)
rubylib.unshift %|#{File.dirname(__FILE__) + '/../../lib'}|
ENV["RUBYLIB"] = rubylib.uniq.join(File::PATH_SEPARATOR)
require 'rubygems'
-require 'aruba/config'
+require 'aruba/configuration'
require 'aruba/cucumber'
require 'fileutils'
require 'pathname'Then I ran I made an additional change: diff --git a/features/support/env.rb b/features/support/env.rb
index 5bb9b85..226bc38 100644
--- a/features/support/env.rb
+++ b/features/support/env.rb
@@ -26,7 +26,7 @@ end
# ENV['EDITOR']="/bin/cat"
Aruba.configure do |config|
- config.before_cmd do |cmd|
+ config.before(:cmd) do |cmd|
SetupSandbox.create_files test_files
# when executing, resolve the SANDBOX_HOME into a real HOME
ENV['HOME'] = Pathname.new(ENV['SANDBOX_HOME']).realpath.to_sAnd this time the tests did run, but I got lots of unexpected |
|
Here's the Cucumber Report: https://reports.cucumber.io/reports/3bce10ce-e653-49cc-8610-b75976b94206 |
|
I had to close and reopen the PR to trigger github actions |
|
Tests should have failed. They passed, so either the added tests are inadequate, or the reported bug does not actually exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only contains test changes for #179 and the tests should fail.