-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort bricks before comparison #149
base: master
Are you sure you want to change the base?
Conversation
Resolves upstream issue voxpupuli#147
Looks like we need to modulesync this to get the builds working. |
I vaguely remember looking at something similar before. |
It does look like the changes in #120 happens to fix the sorting issue. I am testing this in a bit. |
I'm testing and I do believe this will fix the problem but... It also causes other issues because of the renaming/restructuring of facts. This PR is a major (and a positive) change and while it does fix my issue and is still outstanding I am in favor of whatever solution is quickest to deliver to master in order to fix the brick sorting bug that is currently there. Please respond and let me know when and what fix I can expect so I can decide if I need to run a local fork with a fix in place. |
Dear @mdurell, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
Dear @mdurell, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Resolves upstream issue #147