Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port range #87

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Port range #87

wants to merge 3 commits into from

Conversation

AUsatenko
Copy link

Pull Request (PR) description

This PR

  1. Fixes some typos
  2. Adds support for comma-separated port list and dash separated range for Local and Remote ports
  3. Adds support for 'RPC' and 'RPC-EPMap' port ranges for local ports
  4. Adds default description
  5. Makes sure ICMPv4/v6 protocol does not accept ports
  6. Makes sure 'RPC' and 'RPC-EPMap' only use TCP
  7. Adds Win2k3/XP specific check for rule existence

This Pull Request (PR) fixes the following issues

#80

@ofalk
Copy link
Contributor

ofalk commented May 2, 2019

Hi!
I'm pretty low on time these days. Changes make sense, but I do not have the time to review every bit of the code. If anyone else can help out here, that would be awesome!

Thanks,
Oliver

@vox-pupuli-tasks
Copy link

Dear @AUsatenko, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @AUsatenko, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @AUsatenko, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@ds2000
Copy link

ds2000 commented Jan 24, 2020

Port range is definitely needed with this :)

@ds2000
Copy link

ds2000 commented Feb 4, 2020 •
edited
Loading

@ofalk & @AUsatenko - I'm happy to look at the code and resolve the merge conflicts. I'm trying to upgrade our puppet env at work and keeping releases official. I don't really want to hack to changes in as the next person will probably miss them.

Thanks,

@kenyon kenyon mentioned this pull request Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds2000 ds2000 ds2000 approved these changes

Assignees
No one assigned
Labels
merge-conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AUsatenko @ofalk @ds2000 @dhoppe