Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comments are displayed multiple times for merge conflicts #159

Open
bastelfreak opened this issue Apr 30, 2020 · 3 comments · Fixed by #161
Open

comments are displayed multiple times for merge conflicts #159

bastelfreak opened this issue Apr 30, 2020 · 3 comments · Fixed by #161
Labels
backend/eventhandler How incoming data is handled backend/poll-engine How we poll data and handle it bug Something isn't working
Milestone
merge conflicts

Comments

@bastelfreak
Copy link
Member

bastelfreak commented Apr 30, 2020 •
edited
Loading

Basically have a look at voxpupuli/puppet-zabbix#617

If we detect a merge conflict, we sometimes paste two or three comments into a PR. This should not be the case.
@bastelfreak bastelfreak added bug Something isn't working backend/eventhandler How incoming data is handled backend/poll-engine How we poll data and handle it labels Apr 30, 2020
@bastelfreak bastelfreak added this to the merge conflicts milestone Apr 30, 2020
@bastelfreak bastelfreak mentioned this issue Apr 30, 2020
Merged
bastelfreak added a commit that referenced this issue Apr 30, 2020
@bastelfreak
Only add a comment of PR is eligible
f1a094b 
This maybe fixes #159
@bastelfreak bastelfreak mentioned this issue Apr 30, 2020
Merged
bastelfreak added a commit that referenced this issue Apr 30, 2020
@bastelfreak
Only add a comment of PR is eligible
a12096c 
This maybe fixes #159
@bastelfreak bastelfreak reopened this Aug 2, 2020
@bastelfreak
Copy link
Member Author

@Flipez we still have an issue with this. please checkout voxpupuli/puppet-unbound#238

I'm pretty sure that one action, like merging a PR, triggers multiple rescans which causes this error.

@bastelfreak
Copy link
Member Author

another failed one: voxpupuli/puppet-winlogbeat#24 (comment)

@bastelfreak
Copy link
Member Author

to be fair, it works sometimes voxpupuli/puppet-unbound#238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend/eventhandler How incoming data is handled backend/poll-engine How we poll data and handle it bug Something isn't working
Projects
None yet
Milestone
merge conflicts
Development

Successfully merging a pull request may close this issue.

Only add a comment of PR is eligible voxpupuli/vox-pupuli-tasks
1 participant
@bastelfreak