Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial #3 general comments #24

Open
LeoVascelli opened this issue Nov 20, 2018 · 1 comment
Open

Tutorial #3 general comments #24

LeoVascelli opened this issue Nov 20, 2018 · 1 comment

Comments

@LeoVascelli
Copy link

  • start with time-series of hippocampal data that shows some nice oscillation? A bit unclear wo a naive user where the PSD comes from / what frequency space is compared to time space, showing both might help.
  • PSD is not a graphical representation, only if you plot it. It's the frequency representation.
  • Maybe use more than two frequencies for the artificial time-series?
  • remove "a" or "the" from "Generating the a complex sinusoid"
  • Replace "Complex time series" with something else or just ommit complex. Only use complex for signals that have an imaginary and a real part. This issue should be fixed troughout the tutorial.
  • the concep of oscillatory phase appears out of nowhere. Maybe introduce before when looking at time-series? Or introduce in Tutorial Is there going to be python 3 support? #2?
  • "fourier transform followe by the inverse fourier transform without loosing information"?
  • Say something about the resampling that is being performed.
  • log(power) and log(Frequency) as axis labels. or actually log10(power)
  • transform x-axis labels into Hz to help the reader?
@TomDonoghue TomDonoghue changed the title Tutorial #3 comments Tutorial #3 general comments Apr 11, 2019
@meyhaa
Copy link

meyhaa commented May 7, 2019

  • Overall
    • Most of the graphs/visualizations need to have their axes labeled.
  • The FFT of a Complex Sinusoid
    • What is a complex sinusoid? Perhaps provide an external resource?
    • Complex Signal graph needs axes to be labeled
  • Generating the PSD of electrophysiological data
    • ECoG is introduced for the first time as an acronym. It may need a brief explanation.
    • Links to sampling rate tutorial and Jack Schaedler’s interactive guide are both broken
    • More bolded phrases/terms in Slope of the PSD and 1/f power law section

Potential Key Terms for Glossary (list for you to narrow down/edit):
Power Spectral Density
Frequency Domain
Voltage Power
Spectrum
Fourier Transform
Complex Sinusoid (two-component sinusoid)
Phase Offset
ECoG
Complex Signal
Wavelengths (difference in power?)
1/f power law, power law distribution/pink noise
Welch’s Method
Oscillations
Aperiodic slope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants