Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include at least a syntax check into the Docker build #248

Open
Echsecutor opened this issue Jun 9, 2024 · 1 comment
Open

Include at least a syntax check into the Docker build #248

Echsecutor opened this issue Jun 9, 2024 · 1 comment

Comments

@Echsecutor
Copy link
Contributor

It is currently possible to build a Docker image that contains broken (syntactically) python code. We should at least run pyflakes, or maybe even pep8 before shipping the image ;)

@Echsecutor
Copy link
Contributor Author

Just an example from pyflakeing the modules which most likely hints to errors in the code

ghproj.py:11: SyntaxWarning: invalid escape sequence '\{'
  p = re.compile('domains=\{.*\}')
...
mumble.py:91:12: undefined name 'bot'
mumble.py:91:20: undefined name 'event'
mumble.py:91:30: undefined name 'bot'
mumble.py:91:43: undefined name 'event'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant