Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings highlighted incorrectly after var in call #12

Open
m22spencer opened this issue Feb 11, 2017 · 7 comments
Open

Strings highlighted incorrectly after var in call #12

m22spencer opened this issue Feb 11, 2017 · 7 comments
Labels

Comments

@m22spencer
Copy link

This is a regression. Started occurring after updating to vshaxe 1.3.1.
Hope this is the right place to post the bug.

broken-after-var-in-ecall

working-without-var

Text Version:

class X {
    public static function a() {
        foo( var bar = 0
           , 'Specialize ${foo.toString()}'
           );
    }
}
class X {
    public static function a() {
        foo( bar = 0
           , 'Specialize ${foo.toString()}'
           );
    }
}
@m22spencer
Copy link
Author

Just realized vscode keeps the old extensions around. This was working correctly in vshaxe 1.1.1:

working-correctly

@Gama11
Copy link
Member

Gama11 commented Feb 11, 2017

Hope this is the right place to post the bug.

Yes, it is. :)

Started occurring after updating to vshaxe 1.3.1.

I doubt it was specifically 1.3.1, maybe some update before between 1.3.1 and 1.1.1.

@Gama11 Gama11 added the bug label Feb 11, 2017
@Gama11
Copy link
Member

Gama11 commented Feb 11, 2017

Are you sure that's valid syntax in the first case with the var keyword?

Second one is definitely valid: http://try.haxe.org/#dBfA6 (and also appears to be highlighted correctly - I was a bit confused at first, but you're using the plain Dark theme, not Dark+)

But I can't get the first one to compile: http://try.haxe.org/#7a12C

@nadako
Copy link
Member

nadako commented Feb 11, 2017

It's valid for macros

@Gama11
Copy link
Member

Gama11 commented Feb 11, 2017

Ah. I have a feeling there's gonna be a fair number of issues like that...

@Gama11
Copy link
Member

Gama11 commented Feb 11, 2017

Btw, the issue in this particular case is that the grammar file thinks this is a multi-var declaration.

@m22spencer
Copy link
Author

between 1.3.1 and 1.1.1.

Started occurring at vshaxe-1.2.0 (Sorry for not including in the original report)

Ah. I have a feeling there's gonna be a fair number of issues like that...

Indeed. I've still not managed to get haxe entirely understood by cc-mode in emacs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants