Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime-vapor): app.component() #213

Closed
wants to merge 1 commit into from

Conversation

ubugeeei
Copy link
Member

@ubugeeei ubugeeei commented May 19, 2024

relates: #212 #197

TODO:
- [ ] resolve component from app.components

  • test
  • isNativeTag

@ubugeeei ubugeeei marked this pull request as draft May 19, 2024 12:14
Copy link

netlify bot commented May 19, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit fd9b50b
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/6649ed2a41b3bf000824dd19
😎 Deploy Preview https://deploy-preview-213--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 19, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit fd9b50b
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/6649ed2a9673660008a72034
😎 Deploy Preview https://deploy-preview-213--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 55.7 kB 19 kB 17.2 kB
runtime-dom.global.prod.js 94.9 kB 35.8 kB 32.2 kB
runtime-vapor.global.prod.js 45.4 kB (+100 B) 17 kB (+38 B) 15.6 kB (+29 B)
vue-vapor.global.prod.js 98.3 kB (+85 B) 34.5 kB (+32 B) 31.1 kB (-23 B)
vue.global.prod.js 152 kB 55.1 kB 49.2 kB

Usages

Name Size Gzip Brotli
createApp 55.3 kB 21.2 kB 19.4 kB
createSSRApp 58.6 kB 22.5 kB 20.5 kB
defineCustomElement 57.6 kB 21.9 kB 20 kB
vapor 45.8 kB (+99 B) 17.1 kB (+31 B) 15.6 kB (+25 B)
overall 69.1 kB 26.2 kB 23.8 kB

@ubugeeei
Copy link
Member Author

Ah, it overlaps with #212. 😵‍💫

@ubugeeei ubugeeei closed this May 19, 2024
@ubugeeei
Copy link
Member Author

Ah, it overlaps with #212. 😵‍💫

I thought so, but app.component wasn't implemented, so I'll reopen it.

@ubugeeei
Copy link
Member Author

ubugeeei commented May 19, 2024

I thought so, but app.component wasn't implemented, so I'll reopen it.

I thought so, but it overlapped with #214 (I'll close it again).

@ubugeeei ubugeeei closed this May 19, 2024
@sxzz
Copy link
Member

sxzz commented May 19, 2024

Thanks anyway! The original issue #209 is assigned to @Doctor-wu before.

@sxzz sxzz deleted the ubugeeei/feat/app-component branch May 19, 2024 13:05
@ubugeeei
Copy link
Member Author

It's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants