-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate shareable configs #1951
Comments
I'm not sure if that's a good idea. I think most people use the Maybe we can instead create new shareable configs based on other criteria? E.g. "error prevention" and "layout" rules? Or just leave it as it is, and curate the configs ourselves based on good judgement? |
https://vuejs.org/style-guide/ Maybe we can start a project to discuss the new guidance? |
Thank you for your comment.
If we deprecate shareable configs provided by this plugin, I would publish a new shareable config as a personal project. It's probably two configurations like "error prevention" and "layout".
I think it's good to discuss the new(?) style guide. But I'm not sure of the right place to discuss style guides. Additionally, I personally prefer the Options API. Therefore, I am a little worried about whether I can properly participate in the discussion 😅 If we create a new style guide, the following PR might be a good starting point. By the way, if we continue to provide new sharable configs officially, we can consider separating them from this plugin. Changing the shareable configuration is a breaking change and cannot be changed often when shipped with plugins. Separating shareable configurations allows us to keep up with style guide updates. |
Didn't think about this before. But yeah, it sounds good! |
A "deprecated in vue 3" config for use in vue 2 projects wanting to upgrade at some point would be great! |
Hi @thedamon. Your suggestion sounds good, but I'd like to discuss deprecating (or removing) the configuration provided by the plugin in this issue. |
I still think shareable configs should be deprecated. The shareable configuration that plugins currently provide is mostly subjective. Whether or not user use these configurations is user preference and we are not forcing user to do anything. |
What if they're renamed to include the keyword "stylistic" or something like this? |
Sorry. I don't understand English well, so I'm not sure, but if we include the word |
The problem you want to solve.
Most of the shareable configs provided by this plugin are based on style guide.
However, the link to Vue's style guide seems to have been removed.
https://github.com/vuejs/docs/blob/74449a840c88ee9488e2337081302a993e14e1f6/.vitepress/config.ts#L18
vuejs/docs@4acd127
So, I suspect that these configs are based on deprecated documentation.
Your take on the correct solution to problem.
Deprecate shareable configurations other than
plugin:vue/base
.Provide shareable configurations based on the new standards, if needed.
Additional context
https://github.com/vuejs/eslint-plugin-vue/issues?q=label%3A%22matter+of+taste%22
The text was updated successfully, but these errors were encountered: