Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply externalLinkIcon option to root index.md #4212

Open
4 tasks done
thdoan opened this issue Sep 17, 2024 · 7 comments
Open
4 tasks done

Apply externalLinkIcon option to root index.md #4212

thdoan opened this issue Sep 17, 2024 · 7 comments
Labels
bug Something isn't working has-workaround Has workaround, low priority theme Related to the theme

Comments

@thdoan
Copy link

thdoan commented Sep 17, 2024

Is your feature request related to a problem? Please describe.

Currently, when you set externalLinkIcon: true it is not applied to the root index.md.

Describe the solution you'd like

It would be nice to also add the external link icon to external links in the root index.md.

Describe alternatives you've considered

No response

Additional context

No response

Validations

@brc-dd
Copy link
Member

brc-dd commented Sep 18, 2024

Can you explain what you're trying to do?

@thdoan
Copy link
Author

thdoan commented Sep 18, 2024

Please see https://stackblitz.com/edit/vite-ps7x8w?file=docs%2Findex.md

I'm expecting there to be an external link icon similar to the link on the example page for consistency.

@brc-dd brc-dd added bug Something isn't working theme Related to the theme has-workaround Has workaround, low priority labels Sep 18, 2024
@brc-dd
Copy link
Member

brc-dd commented Sep 18, 2024

Ah, I see. For now you can do this:

---
layout: home

pageClass: external-link-icon-enabled

hero:
...

@thdoan
Copy link
Author

thdoan commented Sep 18, 2024

Thank you. Feel free to close as this option works for me.

@brc-dd
Copy link
Member

brc-dd commented Sep 18, 2024

No, we should fix it. Probably a 1-2 line change.

@thdoan
Copy link
Author

thdoan commented Sep 18, 2024

Great. I assume once it's fixed, pageClass will be optional, right.

@brc-dd
Copy link
Member

brc-dd commented Sep 18, 2024

Yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working has-workaround Has workaround, low priority theme Related to the theme
Projects
None yet
Development

No branches or pull requests

2 participants