Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] getters-should-be-side-effect-free #1500

Closed
Mister-Hope opened this issue Feb 18, 2024 · 1 comment
Closed

[Bug report] getters-should-be-side-effect-free #1500

Mister-Hope opened this issue Feb 18, 2024 · 1 comment
Assignees
Labels
package:client upstream bug Bug from upperchain or other tools, env, etc.

Comments

@Mister-Hope
Copy link
Member

Mister-Hope commented Feb 18, 2024

Description

app.js:283 [Vue warn] Computed is still dirty after getter evaluation, likely because a computed is mutating its own dependency in its getter. State mutations in computed getters should be avoided. Check the docs for more details: https://vuejs.org/guide/essentials/computed.html#getters-should-be-side-effect-free

Reproduction

  1. Checkout to branch computed (it has latest deps)
  2. Install deps
  3. Run e2e docs

image

@meteorlxy meteorlxy added the upstream bug Bug from upperchain or other tools, env, etc. label Feb 18, 2024
@meteorlxy
Copy link
Member

See vueuse/vueuse#3794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:client upstream bug Bug from upperchain or other tools, env, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants