Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Replace webpack-chain with webpack-5-chain #1503

Closed
Mister-Hope opened this issue Feb 20, 2024 · 5 comments · Fixed by #1566
Closed

[Bug report] Replace webpack-chain with webpack-5-chain #1503

Mister-Hope opened this issue Feb 20, 2024 · 5 comments · Fixed by #1566
Assignees
@Mister-Hope
Labels
enhancement New feature or request package:bundler-webpack

Comments

@Mister-Hope
Copy link
Member

Mister-Hope commented Feb 20, 2024 •
edited
Loading

Description

Technically speaking, webpack-chain never adds support for webpack v5, and the latest version was published 4 years ago

The maintainer already deprecates the package, so we'd better drop it.

See https://www.npmjs.com/package/webpack-chain
@meteorlxy
Copy link
Member

Any suggested alternatives?

@Mister-Hope
Copy link
Member Author

Mister-Hope commented Feb 21, 2024 •
edited
Loading

Not finding anyalternatives.

Suggest modifying webpack options directly. Even with webpack chain, a lot of v5 options are still hard to modify or add.

This also add a new breaking change that chain webpack is removed.

@github-actions github-actions bot added the stale label Mar 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

@Mister-Hope Mister-Hope removed the stale label Mar 8, 2024
@github-actions github-actions bot added the stale label Mar 24, 2024
@github-actions GitHub Actions
Copy link

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

@Mister-Hope Mister-Hope added enhancement New feature or request and removed stale labels Mar 24, 2024
@Mister-Hope
Copy link
Member Author

https://www.npmjs.com/package/webpack-5-chain

I think this package is widely used, and I would prefer changing to this one.

@Mister-Hope Mister-Hope changed the title [Bug report] Remove webpack-chain [Bug report] Reaplce webpack-chain with webpack-5-chain May 21, 2024
@Mister-Hope Mister-Hope changed the title [Bug report] Reaplce webpack-chain with webpack-5-chain [Bug report] Replace webpack-chain with webpack-5-chain May 21, 2024
@Mister-Hope Mister-Hope assigned Mister-Hope and unassigned meteorlxy May 21, 2024
@Mister-Hope Mister-Hope linked a pull request May 21, 2024 that will close this issue
feat(bundler-webpack): replace webpack-chain with webpack-5-chain (close #1503) #1566
Merged
meteorlxy added a commit that referenced this issue May 22, 2024
@Mister-Hope @meteorlxy
feat(bundler-webpack): replace webpack-chain with webpack-5-chain (close
21ae915 
 #1503) (#1566)

Co-authored-by: meteorlxy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mister-Hope Mister-Hope

Labels
enhancement New feature or request package:bundler-webpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bundler-webpack): replace webpack-chain with webpack-5-chain (close #1503) vuepress/core
2 participants
@meteorlxy @Mister-Hope