Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): support relative path (close #1492) #1521

Closed
wants to merge 12 commits into from
Closed

feat(client): support relative path (close #1492) #1521

wants to merge 12 commits into from

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Mar 25, 2024 •
edited
Loading

This adds:

  • logic changes on isLinkHttp, now link starts with // is considered as http link
  • logic changes on isLinkExternal, now link with protocols will all be treated as external
  • relative link support for normalizeRoutePath resolveRoutePath and resolveRoute
  • A new component <AutoLink> which can be used to render links in plugins and themes

@coveralls
Copy link

coveralls commented Mar 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8689059483

Details

  • 15 of 54 (27.78%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 41.014%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/client/src/router/resolveRoute.ts 0 1 0.0%
packages/client/src/router/resolveRoutePath.ts 0 2 0.0%
packages/client/src/components/RouteLink.ts 0 9 0.0%
packages/client/src/components/AutoLink.ts 0 27 0.0%
Totals Coverage Status
Change from base Build 8685728582: -0.7%
Covered Lines: 689
Relevant Lines: 1715
💛 - Coveralls

@Mister-Hope Mister-Hope requested a review from meteorlxy March 25, 2024 13:41
@Mister-Hope
Copy link
Member Author

@meteorlxy Could you review this? The downstream needs this.

@Mister-Hope Mister-Hope changed the title feat(client): support relative path feat(client): support relative path (close #1492) Apr 6, 2024
@Mister-Hope Mister-Hope linked an issue Apr 6, 2024 that may be closed by this pull request
[Bug report] resolveRoute does not support relative path #1492
Closed
@Mister-Hope Mister-Hope requested a review from meteorlxy April 9, 2024 19:55
@Mister-Hope Mister-Hope mentioned this pull request Apr 11, 2024
Merged
@Mister-Hope Mister-Hope requested a review from meteorlxy April 15, 2024 05:35
@Mister-Hope Mister-Hope deleted the route-relative branch April 17, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorlxy meteorlxy Awaiting requested review from meteorlxy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug report] resolveRoute does not support relative path
3 participants
@Mister-Hope @coveralls @meteorlxy