Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] app.env.isBuild is broken #1612

Closed
Mister-Hope opened this issue Oct 9, 2024 · 2 comments
Closed

[Bug report] app.env.isBuild is broken #1612

Mister-Hope opened this issue Oct 9, 2024 · 2 comments
Assignees
@meteorlxy
Labels
bug Something isn't working package:core regression

Comments

@Mister-Hope
Copy link
Member

Description

app.env.isBuild is broken, and is affecting downstream plugins.

Also I am curious if there could be a 3rd state besides dev and build in future.....

Reproduction

Not needed

Used Package Manager

npm

System Info

.
@Mister-Hope
Copy link
Member Author

@meteorlxy This is introduced by be249ec

This affect the plugins that is using a (app) => pluginApi, where the app here is wrong. The app that could be accessed in hook functions are not affected.

@Mister-Hope Mister-Hope mentioned this issue Oct 9, 2024
Closed
8 tasks
@Mister-Hope
Copy link
Member Author

I suggest revert that commit

@meteorlxy meteorlxy added bug Something isn't working package:core regression labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meteorlxy meteorlxy

Labels
bug Something isn't working package:core regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meteorlxy @Mister-Hope