Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this be used to do live local development of patterns? #256

Open
ZoeBijl opened this issue Sep 7, 2023 · 4 comments
Open

Can this be used to do live local development of patterns? #256

ZoeBijl opened this issue Sep 7, 2023 · 4 comments

Comments

@ZoeBijl
Copy link

ZoeBijl commented Sep 7, 2023

Currently migrating this tooltip pattern to satisfy w3c/aria-practices#127. I’d like to view my edits in my local copy of this website if possible; is there a way to do this?

Simply running the jekyll serve doesn’t seem to do this?

@mcking65
Copy link
Contributor

AFAIK, no. Not saying impossible but rather that it is not something we intended anyone to do.

All content originates in aria-practices. Github actions generate previews for any branch or fork. So, you can test the main content of the page locally. Then, when you want to see that content with the web site chrome, you can create a PR and use the netlify preview.

@ZoeBijl
Copy link
Author

ZoeBijl commented Sep 15, 2023

This sounds like a lot of extra steps to verify that the WAI website CSS/JS isn’t interfering with the pattern example code.

Is this procedure documented anywhere?

@mcking65
Copy link
Contributor

@ZoeBijl wrote:

This sounds like a lot of extra steps to verify that the WAI website CSS/JS isn’t interfering with the pattern example code.

It is one step, create a PR, which will generate a preview. Admittedly, that is not a small step, especially for a new contributor who may want to make such checks before pushing their work into a public space. From that perspective, it is not yet an ideal solution.

On the other hand, a procedure that enables complete offline preview is likely going to be more technically complex. As long as we still have the two-repo architecture, it would probably involve more steps.

For now, we are not investigating consolidation of the content and build repos. We don't have anyone to do that work at this time. In addition, some of the work might have to be re-done in 2024 because WAI is planning to redesign the back-end of the entire WAI site.

Is this procedure documented anywhere?

Not as well as it should be. This has come up in recent discussions of w3c/aria-practices#2734. We have identified a need to make significant changes to the readme to help new contributors.

@a11ydoer
Copy link

a11ydoer commented Sep 26, 2023

@ZoeBijl I also created the issue 2781, "Transfer APG deployment process to Github Wiki page" and assigned it to me. I plan to work on this issue within two weeks timeframe.

The orginal issue 13 in Wai aria practice repo, explains overall processes for PR and Deployement, which will be helpful for further understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants