Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h1 - optional type #30

Open
shawna-slh opened this issue Apr 8, 2022 · 2 comments
Open

h1 - optional type #30

shawna-slh opened this issue Apr 8, 2022 · 2 comments

Comments

@shawna-slh
Copy link
Contributor

shawna-slh commented Apr 8, 2022

Note that the parent design has a provision for including the type in the h1.

For example: "Propose Test Rule:"

For example: "Cognitive Accessibility Design Pattern:"

With HTML title of:

Make Short Critical Paths | Cognitive Accessibility Design Pattern | WAI | W3C
(related to #31 )

This is optional. Fee free to close this issue.

@richnoah
Copy link

richnoah commented May 2, 2022

@isaacdurazo if possible would like your input on this as it applies to the design.

@mcking65
Copy link
Contributor

mcking65 commented May 2, 2022

I have moved this to backlog. We do not have to decide before launch.

The only two strongly typed pages are design patterns and examples. We already include the word "Example" in the H1 of all example pages.

It is not good for screen reader users to front-load a title with higher-level information. If I just navigated to the design pattern page for accordion, I would want to hear the more specific information first, e.g., "Accordion Design Pattern", not "Design Pattern: "Accordion".

Just like for example pages, if we were to do this, I think it would be better to do it in the content rather than programatically. That way we can make editorial adjustments where appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants