Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "Read me first" content from "About" page to its own page within fundamentals section #48

Closed
mcking65 opened this issue May 3, 2022 · 7 comments

Comments

@mcking65
Copy link
Contributor

mcking65 commented May 3, 2022

The content from the section Read me first needs to have its own fundamentals page that is a sibling of the sections for landmarks and accessible names. It is currently buried in the "About" page; it should be removed from there.

Per suggestion from @shawna-slh, change the title to "Read This First".

List it first on the fundamentals page.

Also List it first on the patterns and widgets page.

We will also need to find a good spot for it on the home page, perhaps as the first resource.

@richnoah
Copy link

richnoah commented May 3, 2022

@mcking65 for the request of listing the Read This First content on the Patterns and Widgets page are you wanting this in a card or in a new design element? The cards on the page are currently ordered alphabetically and inserting this content would break that organizational structure.

Is the request for including this information on the homepage a requirement for launch or more of a long-term vision?

@mcking65
Copy link
Contributor Author

mcking65 commented May 3, 2022

@richnoah

For launch, it is essential that it is first on fundamentals page.

For launch, there will also have to be at least one of either a patterns or home page placement requirement, but I want to discuss it first at today's meeting.

@richnoah
Copy link

richnoah commented May 4, 2022

Per a discussion during the TF meeting on 5/3 the following items are deliverables for this issue:

  • Create a new page titled Read This First using the content from the About Page for the sections with headings of No ARIA is better than Bad ARIA, Browser, and Assistive Technology Support, and Mobile and Touch Support.
  • Include the headings of No ARIA is Better than Bad ARIA, Assistive Technology Support, and Mobile and Touch Support in the table of contents
  • On the Fundamentals page include a link named "Read This First" and the text "No ARIA is bettern than bad ARIA!" under the H1 and before the cards
  • On the Design Patterns and Widgets page include a link named "Read This First" and the text "No ARIA is bettern than bad ARIA!" under the H1 and before the cards
  • On the About Page, remove the sections with headings of No ARIA is better than Bad ARIA, Browser, and Assistive Technology Support, and Mobile and Touch Support.

@mcking65
Copy link
Contributor Author

mcking65 commented May 4, 2022

@richnoah, @isaacdurazo, note that I made minor clarifications to the to-do list in Rich's comment.

@mcking65
Copy link
Contributor Author

mcking65 commented May 11, 2022

Yesterday this was addressed. Today, in the preview of #62, the link on the practices page to read this first page is broken.

I suspect that the WIP on #60 has broken links to all the patterns and practices?

@mcking65
Copy link
Contributor Author

mcking65 commented May 11, 2022

The links are all fixed in the preview of #62, and I have checked off 3 of 5 to-do items for this issue that are addressed. The other two depend on closing #58 by merging #63.

@mcking65
Copy link
Contributor Author

Verified still fixed after today's changes to #62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants