You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That is, // is just a weakly-binding /, allowing you to define groups inline without having to abstract them to types. The current definition of browser.SetClientWindowStateParameters is:
That is, the first two items form a group, and the third item forms an alternative group. But I suspect what was intended was for clientWindow to always be present, and then have a choice between browser.ClientWindowNamedState and browser.ClientWindowRectState. To do that, you would need to have written:
Thank you @tabatkins for the issue. This is correct. The // operator binds more weakly and we need the choice here. Would you be interested to provide a PR for it?
tabatkins
added a commit
to tabatkins/webdriver-bidi
that referenced
this issue
Jan 14, 2025
If I'm understanding the CDDL spec correctly, and inferring the intended definition of
browser.SetClientWindowStateParameters
correctly, thenbrowser.SetClientWindowStateParameters
is defined incorrectly; it uses//
when it meant to use/
.That is,
//
is just a weakly-binding/
, allowing you to define groups inline without having to abstract them to types. The current definition ofbrowser.SetClientWindowStateParameters
is:This is, afaict, equivalent to:
That is, the first two items form a group, and the third item forms an alternative group. But I suspect what was intended was for
clientWindow
to always be present, and then have a choice betweenbrowser.ClientWindowNamedState
andbrowser.ClientWindowRectState
. To do that, you would need to have written:The text was updated successfully, but these errors were encountered: