Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match_origin_as_fallback in content_scripts declaration #482

Open
oliverdunk opened this issue Nov 3, 2023 · 3 comments
Open

match_origin_as_fallback in content_scripts declaration #482

oliverdunk opened this issue Nov 3, 2023 · 3 comments
Labels
follow-up: safari Needs a response from a Safari representative implemented: chrome Implemented in Chrome implemented: firefox Implemented in Firefox inconsistency Inconsistent behavior across browsers

Comments

@oliverdunk
Copy link
Member

Chrome supports the match_origin_as_fallback key which allows content scripts to be injected into pages like about:, data: and blob: based on the host's origin. This is not currently supported in Firefox (although support was expressed in #285) or Safari.

Opening this to track the specific key which is related, and likely to be fixed at the same time as, (but somewhat separate) to the problem discussed in #285.

@oliverdunk oliverdunk added inconsistency Inconsistent behavior across browsers implemented: chrome Implemented in Chrome supportive: firefox Supportive from Firefox follow-up: safari Needs a response from a Safari representative labels Nov 3, 2023
@Rob--W
Copy link
Member

Rob--W commented Nov 6, 2023

FYI from Firefox's perspective I am not only supportive, but I was also involved in the design of the API as expressed at #285 (comment) .

Would you also include the scripting API in this topic? Going forward, we should ideally consider manifest-declared content_scripts along with content scripts registered in the scripting API.

In Firefox, we have this tracking bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1853411 ("Implement matchOriginAsFallback in the scripting.registerContentScripts API")

@oliverdunk
Copy link
Member Author

Would you also include the scripting API in this topic?

I think that makes sense :)

@Rob--W
Copy link
Member

Rob--W commented May 20, 2024

This has been implemented in Firefox 128.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow-up: safari Needs a response from a Safari representative implemented: chrome Implemented in Chrome implemented: firefox Implemented in Firefox inconsistency Inconsistent behavior across browsers
Projects
None yet
Development

No branches or pull requests

2 participants