Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chem-Sep Equations Refactor #10

Open
Mahaki-Leach opened this issue Nov 25, 2024 · 0 comments
Open

Chem-Sep Equations Refactor #10

Mahaki-Leach opened this issue Nov 25, 2024 · 0 comments

Comments

@Mahaki-Leach
Copy link
Collaborator

Since Chem-Sep property formulations are already built in a modular format (equation numbers relating to specific forms of equations) i.e.
image
we will refactor the config generation to be entirely reliant on the Chem-Sep class i.e. removing the usage of Perry's, RPP4, RPP3, etc and instead creating a modular implementation of chem-sep equations as they are needed and reused between properties.
image
which should remove all code like this within the parsing logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant